Heroes of Might and Magic Community
visiting hero! Register | Today's Posts | Games | Search! | FAQ/Rules | AvatarList | MemberList | Profile


Age of Heroes Headlines:  
5 Oct 2016: Heroes VII development comes to an end.. - read more
6 Aug 2016: Troubled Heroes VII Expansion Release - read more
26 Apr 2016: Heroes VII XPack - Trial by Fire - Coming out in June! - read more
17 Apr 2016: Global Alternative Creatures MOD for H7 after 1.8 Patch! - read more
7 Mar 2016: Romero launches a Piano Sonata Album Kickstarter! - read more
19 Feb 2016: Heroes 5.5 RC6, Heroes VII patch 1.7 are out! - read more
13 Jan 2016: Horn of the Abyss 1.4 Available for Download! - read more
17 Dec 2015: Heroes 5.5 update, 1.6 out for H7 - read more
23 Nov 2015: H7 1.4 & 1.5 patches Released - read more
31 Oct 2015: First H7 patches are out, End of DoC development - read more
5 Oct 2016: Heroes VII development comes to an end.. - read more
[X] Remove Ads
LOGIN:     Username:     Password:         [ Register ]
HOMM1: info forum | HOMM2: info forum | HOMM3: info mods forum | HOMM4: info CTG forum | HOMM5: info mods forum | MMH6: wiki forum | MMH7: wiki forum
Heroes Community > Heroes 3.5 - WoG and Beyond > Thread: ERA II - Source code - Help and discussion
Thread: ERA II - Source code - Help and discussion This thread is 4 pages long: 1 2 3 4 · «PREV
gamemaster
gamemaster


Hired Hero
posted February 01, 2020 11:50 PM

Nice.
I just stumped on it and remember that FU was changed recently, while line 619 remain same.

Good to know that all is under control

 Send Instant Message | Send E-Mail | View Profile | Quote Reply | Link
gamemaster
gamemaster


Hired Hero
posted February 04, 2020 07:16 PM
Edited by gamemaster at 19:30, 04 Feb 2020.

Hi

Anything changed in d2 library in new patch 2.9.8?
Can you upload to git if it changed.

What is meaning of tags in code:
{U} {n} {!} {O} ...
Are they added by third party software?
Perhaps GExperts or CnPack?

 Send Instant Message | Send E-Mail | View Profile | Quote Reply | Link
Bersy
Bersy


Honorable
Supreme Hero
posted February 04, 2020 08:20 PM

Hi, nothing changed.
Tags are custom way to mark memory ownage.
{O} means unit or procedure Owns class instance/heap pointer. It's responsible for item creation/freeing.
{U} means, that procedure or unit Uses reference to resource, but is not responsible for its deallocation.
{n} means, that pointer can be Nil (it's allowed and no need in asserting, that it's not nil).
{!} simple comment to highlight assertion or some other construction like critical section enter/leave.
____________
Heroes 3 Era and everything for it. Releases folder for releases.

 Send Instant Message | Send E-Mail | View Profile | Quote Reply | Link
gamemaster
gamemaster


Hired Hero
posted February 09, 2020 02:05 PM

Hi,

I come to Heroes.pas file.
It seems that Delphi XE has small problem with one structure

Is there any consequence if we make separate record and use it instead declaring record in place.
For example

TGlobalEvents = packed record
 First, Last, Dummy: PGlobalEvent;
end;
...
GlobalEvents: TGlobalEvents;
...


Problem is related to cosmetic and productivity. In this file half of code can not be folded and Ctr+click does not work for all declarations below this record.
It is delphi bug i guess.
Also you should avoid inplace record declaration if possible to avoid future problems.

 Send Instant Message | Send E-Mail | View Profile | Quote Reply | Link
Bersy
Bersy


Honorable
Supreme Hero
posted February 09, 2020 05:10 PM

Inplace declarations of arrays and records were not a problem. It's definitely IDE issue with folding only, but ok.
____________
Heroes 3 Era and everything for it. Releases folder for releases.

 Send Instant Message | Send E-Mail | View Profile | Quote Reply | Link
gamemaster
gamemaster


Hired Hero
posted February 16, 2020 09:47 PM

Hi


Do you know what is meaning of exclamation mark near interface in structure tree?
I can not find any reason why compiler make that note.
There is no warning or hint related to interfaces. It compile and game work (at least first few days i tested ).

Just need to know is that something that need investigation or i can skip it.

 Send Instant Message | Send E-Mail | View Profile | Quote Reply | Link
Jump To: « Prev Thread . . . Next Thread » This thread is 4 pages long: 1 2 3 4 · «PREV
Post New Poll    Post New Topic    Post New Reply

Page compiled in 0.0387 seconds