Heroes of Might and Magic Community
visiting hero! Register | Today's Posts | Games | Search! | FAQ/Rules | AvatarList | MemberList | Profile


Age of Heroes Headlines:  
5 Oct 2016: Heroes VII development comes to an end.. - read more
6 Aug 2016: Troubled Heroes VII Expansion Release - read more
26 Apr 2016: Heroes VII XPack - Trial by Fire - Coming out in June! - read more
17 Apr 2016: Global Alternative Creatures MOD for H7 after 1.8 Patch! - read more
7 Mar 2016: Romero launches a Piano Sonata Album Kickstarter! - read more
19 Feb 2016: Heroes 5.5 RC6, Heroes VII patch 1.7 are out! - read more
13 Jan 2016: Horn of the Abyss 1.4 Available for Download! - read more
17 Dec 2015: Heroes 5.5 update, 1.6 out for H7 - read more
23 Nov 2015: H7 1.4 & 1.5 patches Released - read more
31 Oct 2015: First H7 patches are out, End of DoC development - read more
5 Oct 2016: Heroes VII development comes to an end.. - read more
[X] Remove Ads
LOGIN:     Username:     Password:         [ Register ]
HOMM1: info forum | HOMM2: info forum | HOMM3: info mods forum | HOMM4: info CTG forum | HOMM5: info mods forum | MMH6: wiki forum | MMH7: wiki forum
Heroes Community > Heroes 3.5 - WoG and Beyond > Thread: ERA II - Source code - Help and discussion
Thread: ERA II - Source code - Help and discussion This thread is 9 pages long: 1 2 3 4 5 6 7 8 9 · «PREV / NEXT»
gamemaster
gamemaster


Adventuring Hero
posted April 12, 2020 02:13 PM
Edited by gamemaster at 14:14, 12 Apr 2020.

@Bersy

Last commit (12d1f35) on github is unfinished, work in progress?

There are lot problems with VR receiver.
All but !#VR:S is unrecognized and produce error message.
All !!VR produce arithmetic error.

Tested with wog and basic scripts only.

 Send Instant Message | Send E-Mail | View Profile | Quote Reply | Link
Bersy
Bersy


Honorable
Supreme Hero
posted April 13, 2020 12:36 AM

Right, current commits will no be fully playable until all subcommands are rewritten. Feature like ^...^ literals in most ERM commands already works, but IF:M/Q at least require changing.
____________
Heroes 3 Era and everything for it. Releases folder for releases.

 Send Instant Message | Send E-Mail | View Profile | Quote Reply | Link
gamemaster
gamemaster


Adventuring Hero
posted April 22, 2020 10:21 PM

in last commit (519b27a):

is operation involving +^...^ still work in progress?

 Send Instant Message | Send E-Mail | View Profile | Quote Reply | Link
Bersy
Bersy


Honorable
Supreme Hero
posted April 25, 2020 07:25 PM

I noticed the same bug, will be fixed soon. Thank you.
____________
Heroes 3 Era and everything for it. Releases folder for releases.

 Send Instant Message | Send E-Mail | View Profile | Quote Reply | Link
bloodsucker
bloodsucker


Legendary Hero
posted May 19, 2020 07:09 PM
Edited by bloodsucker at 20:02, 19 May 2020.

Hi, I haven't been playing Wog/Era for quite sometime but suddenly I remembered some stuff and wanted to make a few suggestions. I'm not sure where they would fit, so decided to make them here. Sorry for the inconvenience.
1. The week of the creature script doesn't save the actual parameters of the creature, so when the week ends it returns them to the original. If you have used the Emerald Tower or similar to change them, you lose everything. It would be a good idea to save those values and return them to where they were.
2. If you maintain the decision of keeping the Emerald Towers bugged so they work only once, something I wish you reconsidered, then I think it would be better to create a simpler object with less interactions, since many end up making no sense. It should have a fight instead of a cost, since that's how one time visit objects generally work.
____________
The only reason i argue with you people is because i don't want the bullsnow you all spout to be so easily spread to the impressionable without another sane voice challenging you.  -  Fred79

 Send Instant Message | Send E-Mail | View Profile | Quote Reply | Link
RerryR
RerryR


Promising
Famous Hero
Researching Magic
posted May 19, 2020 08:35 PM

I never knew the reason for this bug, but that makes sense.
Maybe I can change it.

 Send Instant Message | Send E-Mail | View Profile | Quote Reply | Link
bloodsucker
bloodsucker


Legendary Hero
posted May 19, 2020 09:23 PM

Thx.
____________
The only reason i argue with you people is because i don't want the bullsnow you all spout to be so easily spread to the impressionable without another sane voice challenging you.  -  Fred79

 Send Instant Message | Send E-Mail | View Profile | Quote Reply | Link
Salamandre
Salamandre


Admirable
Omnipresent Hero
Wog refugee
posted May 19, 2020 09:58 PM
Edited by Salamandre at 22:00, 19 May 2020.

Well the error with emerald towers is here, a simple typo y-1/v1

!!UN:U63/65/?y-1; [Number of Emerald Towers: v1]
!!VRv1:S-1; [Initialize v1 to -1 to work with new faster UN:U syntax]
!!DO10910/1/v1/1&y-1>0:P; [Loop through all Emerald Towers]

Strange that we didn't fix it in wog revised.

 Send Instant Message | Send E-Mail | View Profile | Quote Reply | Link
RerryR
RerryR


Promising
Famous Hero
Researching Magic
posted May 19, 2020 10:15 PM
Edited by RerryR at 22:19, 19 May 2020.

Salamandre said:
Well the error with emerald towers is here, a simple typo y-1/v1

!!UN:U63/65/?y-1; [Number of Emerald Towers: v1]
!!VRv1:S-1; [Initialize v1 to -1 to work with new faster UN:U syntax]
!!DO10910/1/v1/1&y-1>0:P; [Loop through all Emerald Towers]

Strange that we didn't fix it in wog revised.


Thanks, I will forward to Igrik, so it can be included in the next WoG scripts update.

Edit: In the current Git reposit it seems already correct.

 Send Instant Message | Send E-Mail | View Profile | Quote Reply | Link
bloodsucker
bloodsucker


Legendary Hero
posted May 19, 2020 11:31 PM

Salamandre said:
Strange that we didn't fix it in wog revised.

You decided not to because Emerald Towers are broken for AI, at least as far as I recall it.
____________
The only reason i argue with you people is because i don't want the bullsnow you all spout to be so easily spread to the impressionable without another sane voice challenging you.  -  Fred79

 Send Instant Message | Send E-Mail | View Profile | Quote Reply | Link
Salamandre
Salamandre


Admirable
Omnipresent Hero
Wog refugee
posted May 19, 2020 11:45 PM

I don't think so, probably I ignored it because other priorities. If it was broken, we would have fixed at least the typo and set them at visit once only, as it is now is just script with error.

 Send Instant Message | Send E-Mail | View Profile | Quote Reply | Link
bloodsucker
bloodsucker


Legendary Hero
posted May 20, 2020 12:20 AM
Edited by bloodsucker at 00:21, 20 May 2020.

I don't want to start a discussion when I'm getting what I want but you knew how to solve it (did it for your own maps) and instead of a fix there is a comment on the Wog Options page stating that the Emerald Tower only works once in Era.
____________
The only reason i argue with you people is because i don't want the bullsnow you all spout to be so easily spread to the impressionable without another sane voice challenging you.  -  Fred79

 Send Instant Message | Send E-Mail | View Profile | Quote Reply | Link
Salamandre
Salamandre


Admirable
Omnipresent Hero
Wog refugee
posted May 20, 2020 07:00 AM

Yeah probably because a lot of custom maps already used this feature so fixing it would have make them unplayable. But then I should have fixed it in wog revised, I don't remember why I didn't, especially with such tiny error.

 Send Instant Message | Send E-Mail | View Profile | Quote Reply | Link
bloodsucker
bloodsucker


Legendary Hero
posted May 20, 2020 09:22 AM

Btw, in english You is both singular and plural, I'm not saying "Salamandre took this decision", just that it was a decision.
____________
The only reason i argue with you people is because i don't want the bullsnow you all spout to be so easily spread to the impressionable without another sane voice challenging you.  -  Fred79

 Send Instant Message | Send E-Mail | View Profile | Quote Reply | Link
gamemaster
gamemaster


Adventuring Hero
posted May 31, 2020 09:55 PM
Edited by gamemaster at 22:30, 31 May 2020.

@Bersy

Last build "43fdcd5" ported.

This error is presented also in '2c0d42a' commit but not in commits before.
Occurs on mouse enter to town screen.

Edit:
Problem is with 'GetZVarAddr'. It is not replaced in all places with 'GetInterpolatedZVarAddr'.
Erm.pas(6097): Value.pc:= GetZVarAddr(Value.v);
Erm.pas(6100): Value.pc:= GetZVarAddr(Value.v);


Another question:
Is it possible to add 3rd button to "Ask" function.
Or at least detect Shift+click,
Or any other option to get result beside 'ok' and 'cancel' in "Ask" function that is used to report error in game.

 Send Instant Message | Send E-Mail | View Profile | Quote Reply | Link
Bersy
Bersy


Honorable
Supreme Hero
posted June 01, 2020 02:20 AM

Hi, gamemaster!
Thank you for attention and reports.

Erm.pas(6097): Value.pc:= GetZVarAddr(Value.v);
No sense for interpolation of base writable z-var. ERT-vars do not pass IsMutableZVarIndex check.

Same with 6100:
Base string var of non-z type is global named variable s^...^ (SN:W^...^). During GetErmParamValue call it's interpolated automatically and saved as temporal z-variable.

I was not able to reproduce your error. Released Era 3.0.0 alpha package. Could you extract proof-of-concept short ERM code for testing?

"Ask" function is a wrapper upon Msg. No such functionality is in default Heroes 3 dialog. You can use Msg function wrapper and specify 2 images and MES_MAY_CHOOSE type. See IF:Q in ERM help for details. 2 images for selection + ok/cancel buttons. 3 variants.
____________
Heroes 3 Era and everything for it. Releases folder for releases.

 Send Instant Message | Send E-Mail | View Profile | Quote Reply | Link
gamemaster
gamemaster


Adventuring Hero
posted June 01, 2020 02:10 PM

I will recheck above problem.

I will try change ask wrapper to msg as you suggested.

Another thing in Erm.pas:
function IsMutableZVarIndex (Ind: integer): boolean;
begin
 result := ((Ind >= Low(z^)) or (Ind <= High(z^))) or (-Ind in [Low(nz^)..High(nz^)]);
end;


If i am right this function should return true if index is in range 1 to 1000 and -1 to -10.
It will return true even for z-25 because first 'or'.
Perhaps first 'or' should be 'and'.
Just recheck this code.
For now i did not detect any problem with this merely because there are no script that has z-25 or so...

 Send Instant Message | Send E-Mail | View Profile | Quote Reply | Link
Bersy
Bersy


Honorable
Supreme Hero
posted June 01, 2020 02:54 PM

Fixed. Thank you.
____________
Heroes 3 Era and everything for it. Releases folder for releases.

 Send Instant Message | Send E-Mail | View Profile | Quote Reply | Link
gamemaster
gamemaster


Adventuring Hero
posted June 01, 2020 04:03 PM

Regarding problem with 'GetZVarAddr'. There is no problem. I made mistake during test.





 Send Instant Message | Send E-Mail | View Profile | Quote Reply | Link
Bersy
Bersy


Honorable
Supreme Hero
posted June 01, 2020 10:28 PM

Ok. I should probably start making ERM Testing mod, testing commands, where bugs where found to prevent regressions.
____________
Heroes 3 Era and everything for it. Releases folder for releases.

 Send Instant Message | Send E-Mail | View Profile | Quote Reply | Link
Jump To: « Prev Thread . . . Next Thread » This thread is 9 pages long: 1 2 3 4 5 6 7 8 9 · «PREV / NEXT»
Post New Poll    Post New Topic    Post New Reply

Page compiled in 0.0500 seconds