Heroes of Might and Magic Community
visiting hero! Register | Today's Posts | Games | Search! | FAQ/Rules | AvatarList | MemberList | Profile


Age of Heroes Headlines:  
5 Oct 2016: Heroes VII development comes to an end.. - read more
6 Aug 2016: Troubled Heroes VII Expansion Release - read more
26 Apr 2016: Heroes VII XPack - Trial by Fire - Coming out in June! - read more
17 Apr 2016: Global Alternative Creatures MOD for H7 after 1.8 Patch! - read more
7 Mar 2016: Romero launches a Piano Sonata Album Kickstarter! - read more
19 Feb 2016: Heroes 5.5 RC6, Heroes VII patch 1.7 are out! - read more
13 Jan 2016: Horn of the Abyss 1.4 Available for Download! - read more
17 Dec 2015: Heroes 5.5 update, 1.6 out for H7 - read more
23 Nov 2015: H7 1.4 & 1.5 patches Released - read more
31 Oct 2015: First H7 patches are out, End of DoC development - read more
5 Oct 2016: Heroes VII development comes to an end.. - read more
[X] Remove Ads
LOGIN:     Username:     Password:         [ Register ]
HOMM1: info forum | HOMM2: info forum | HOMM3: info mods forum | HOMM4: info CTG forum | HOMM5: info mods forum | MMH6: wiki forum | MMH7: wiki forum
Heroes Community > Library of Enlightenment > Thread: [H3] SoD_SP: a HDmod plugin
Thread: [H3] SoD_SP: a HDmod plugin This thread is 22 pages long: 1 2 3 4 5 ... 10 ... 18 19 20 21 22 · «PREV / NEXT»
RoseKavalier
RoseKavalier


Admirable
Supreme Hero
posted April 01, 2020 03:47 PM

I suggest disabling the BattleQueue Panel (F12 or through ini) until I have had time to update.

@FirePaladin
There's no way to go about it, there is extra room needed to make SoD_SP's panels (1074x660) or HDmod's panel(?); if you insist on having standard resolution then you will not be able to get the BQ.
____________
My Let's Plays: Metataxer's Revenge - The Empire of The World 2

 Send Instant Message | Send E-Mail | View Profile | PP | Quote Reply | Link
FirePaladin
FirePaladin


Supreme Hero
Undercover modder
posted April 01, 2020 03:53 PM

RoseKavalier said:
I suggest disabling the BattleQueue Panel (F12 or through ini) until I have had time to update.

@FirePaladin
There's no way to go about it, there is extra room needed to make SoD_SP's panels (1074x660) or HDmod's panel(?); if you insist on having standard resolution then you will not be able to get the BQ.


Technically, it should still be doable. However, not giving the standard resolution this important update, is not too nice. After all, many old players don't give a something about the higher resolutions and will play the standard (like me, but I'm a more recent player) because the others are ugly. Anyway, I kinda closed this discussion on the other thread. Also, thanks for informing me about the possibility of disabling it in the .ini file. I thought it was incorporated entirely, that's why I didn't bother with the file in the first place.

 Send Instant Message | Send E-Mail | View Profile | PP | Quote Reply | Link
RoseKavalier
RoseKavalier


Admirable
Supreme Hero
posted April 02, 2020 03:00 AM

1.18.6

DOWNLOAD (exe installer)
DOWNLOAD (zip archive)



Version 1.18.6
[+] The BattleQueue Panel option will now toggle between SoD_SP's and HDmod's if the latter is active
Note: the Quickspell and BattleQueue panels are now created programatically
[ ] Updated H3.TextColor to latest version
[-] Fixed the appearance of some Advanced Dialogs (thanks wenwell)


____________
My Let's Plays: Metataxer's Revenge - The Empire of The World 2

 Send Instant Message | Send E-Mail | View Profile | PP | Quote Reply | Link
Machberet
Machberet


Hired Hero
posted April 02, 2020 02:18 PM

RoseKavalier said:
DOWNLOAD (exe installer)
DOWNLOAD (zip archive)



Version 1.18.6
[+] The BattleQueue Panel option will now toggle between SoD_SP's and HDmod's if the latter is active
Note: the Quickspell and BattleQueue panels are now created programatically
[ ] Updated H3.TextColor to latest version
[-] Fixed the appearance of some Advanced Dialogs (thanks wenwell)




There are still problems, if start a fight with HDmod queue on and SoD SP queue turned off. Since SoD SP queue takes precedence, if I turn on SoD SP queue during battle, I get violation error every time a creature moves. After trying to cast a spell - crash. One time trying to enable SoD SP queue just crashed the game with no info prompt.

 Send Instant Message | Send E-Mail | View Profile | Quote Reply | Link
RoseKavalier
RoseKavalier


Admirable
Supreme Hero
posted April 02, 2020 03:13 PM

1.18.7

DOWNLOAD (exe installer)
DOWNLOAD (zip archive)



Version 1.18.7
[-] Fixed a typo that would prevent SoD_SP's BattleQeueue from being fully disabled



Thanks Machberet, I guess I didn't test enough the modified code... a single typo was responsible for a safety check from being done
____________
My Let's Plays: Metataxer's Revenge - The Empire of The World 2

 Send Instant Message | Send E-Mail | View Profile | PP | Quote Reply | Link
Machberet
Machberet


Hired Hero
posted April 03, 2020 01:53 PM

RoseKavalier said:
DOWNLOAD (exe installer)
DOWNLOAD (zip archive)



Version 1.18.7
[-] Fixed a typo that would prevent SoD_SP's BattleQeueue from being fully disabled



Thanks Machberet, I guess I didn't test enough the modified code... a single typo was responsible for a safety check from being done


No problem!

It also seems that Bara also updated HD-mod accordingly. ďż5.0 RC86 -> 5.0 RC87 (04/03/2020)

[-] The battle queue is now disabled if the SoD_SP plugin is used

I wonder what were the difficulties that led him to put the battle queue option BEFORE the game, but not inside (in battle or adventure map).
Because of that, it now creates problems when two players do not agree about the usage of the battle queue, which will happen quite often. Pro player find this queue expendable and obstructing battlelog for example. It is also hard to regulate in tournaments...


 Send Instant Message | Send E-Mail | View Profile | Quote Reply | Link
FirePaladin
FirePaladin


Supreme Hero
Undercover modder
posted April 03, 2020 06:51 PM

One more thing: what .ini are you talking about exactly?

 Send Instant Message | Send E-Mail | View Profile | PP | Quote Reply | Link
Machberet
Machberet


Hired Hero
posted April 05, 2020 01:36 AM
Edited by Machberet at 01:37, 05 Apr 2020.

FirePaladin said:
One more thing: what .ini are you talking about exactly?


Sod_SP.ini in _HD3_Data/Packs/SoD_SP

# The right hand side of the combat window displays a panel with the upcoming move order of creatures.
(...)
BattleQueuePanel = 1

 Send Instant Message | Send E-Mail | View Profile | Quote Reply | Link
bestban
bestban

Tavern Dweller
posted April 19, 2020 11:33 PM

I'm having quite a number of random crashes when entering the combat screen. The combat screen flashed briefly, and the game crashed. This crash happens in about 1 out of 3 combats. After the game gets reloaded from the auto save, the same combat appears fine. It can't be reproduced exactly. This happens randomly.

My setup: GOG HoMM 3 Complete, HD 5.0 RC90 (the crash happens for prior versions as well), SoD_SP v1.18.7, and no other plugins.
Log here: https://drive.google.com/open?id=1zo4Lw_snR_-mT5VY0PFEcBz-AeQKlhz1

Thanks for sharing this great plugin.
____________

 Send Instant Message | Send E-Mail | View Profile | Quote Reply | Link
RoseKavalier
RoseKavalier


Admirable
Supreme Hero
posted April 20, 2020 02:44 AM

bestban said:
I'm having quite a number of random crashes when entering the combat screen. The combat screen flashed briefly, and the game crashed. This crash happens in about 1 out of 3 combats. After the game gets reloaded from the auto save, the same combat appears fine. It can't be reproduced exactly. This happens randomly.

My setup: GOG HoMM 3 Complete, HD 5.0 RC90 (the crash happens for prior versions as well), SoD_SP v1.18.7, and no other plugins.
Log here: https://drive.google.com/open?id=1zo4Lw_snR_-mT5VY0PFEcBz-AeQKlhz1

Thanks for sharing this great plugin.


Update CombatAnimation and report back.
____________
My Let's Plays: Metataxer's Revenge - The Empire of The World 2

 Send Instant Message | Send E-Mail | View Profile | PP | Quote Reply | Link
bestban
bestban

Tavern Dweller
posted April 20, 2020 09:09 AM

RoseKavalier said:

Update CombatAnimation and report back.


A crash using the new H3.CombatAnimation.dll from the link above:
https://drive.google.com/open?id=171ZHkzDt_g70R8elRWDblZqRp7Cfv32Q
Thanks.
____________

 Send Instant Message | Send E-Mail | View Profile | Quote Reply | Link
RoseKavalier
RoseKavalier


Admirable
Supreme Hero
posted April 20, 2020 02:56 PM
Edited by RoseKavalier at 22:37, 20 Apr 2020.

It's definitely CombatAnimation, but I am completely unable to reproduce this. Uninstall it (rename the extension to .bak or something) in the meantime while I try to figure out something.

Do you have any specific battles or is it any random battle? If not any random battles, a save might help.

Also I should note that HDmod is still loading the old CombatAnimation, I guess its detection method for extension type is faulty. Either delete it or change the extension.

Quote:
  0x5B720000: H3.CombatAnimation.dll (size: 0x00016000, entry point: 0x5B7219FF) - C:GOG GamesHoMM 3 Complete_HD3_DataPacksSoD_SPH3.CombatAnimation.dll

[...]
 
  0x5B650000: H3.CombatAnimation.dll-old (size: 0x00016000, entry point: 0x5B6519FF) - C:GOG GamesHoMM 3 Complete_HD3_DataPacksSoD_SPH3.CombatAnimation.dll-old

____________
My Let's Plays: Metataxer's Revenge - The Empire of The World 2

 Send Instant Message | Send E-Mail | View Profile | PP | Quote Reply | Link
bestban
bestban

Tavern Dweller
posted April 21, 2020 09:15 AM
Edited by bestban at 12:10, 21 Apr 2020.

RoseKavalier said:
It's definitely CombatAnimation, but I am completely unable to reproduce this. Uninstall it (rename the extension to .bak or something) in the meantime while I try to figure out something.

Do you have any specific battles or is it any random battle? If not any random battles, a save might help.

Also I should note that HDmod is still loading the old CombatAnimation, I guess its detection method for extension type is faulty. Either delete it or change the extension.
...


This is interesting that .dll-old file got picked up! I'll move it out completely. This crash randomly happens. If I get a reproducible case, then I'll report back (or a crash with new .dll only). I've finished a scenario and will report back after a new game kicks off (may have delay though). Thanks.

____________

 Send Instant Message | Send E-Mail | View Profile | Quote Reply | Link
bestban
bestban

Tavern Dweller
posted April 22, 2020 07:43 AM

RoseKavalier said:
It's definitely CombatAnimation, but I am completely unable to reproduce this. Uninstall it (rename the extension to .bak or something) in the meantime while I try to figure out something.
...



I attempted to reload some old saves with save time right before crashes, and did encounter two crashes; however, unable to repeat unfortunately. Also, somehow the logs are no longer being generated under "...SoD_SPDebug" for new crashes.

Since the access violation shows "read of address: 0x00000030" from the log, does it look more likely a null pointer problem with an offset for member data? From the _HH_CycleCombatScreen, there are two without verification on null: "combat" and "mon". Could one of them somehow be null? I'm unfamiliar with the code and could miss totally though.

 Send Instant Message | Send E-Mail | View Profile | Quote Reply | Link
RoseKavalier
RoseKavalier


Admirable
Supreme Hero
posted April 22, 2020 02:50 PM

bestban said:
Since the access violation shows "read of address: 0x00000030" from the log, does it look more likely a null pointer problem with an offset for member data? From the _HH_CycleCombatScreen, there are two without verification on null: "combat" and "mon". Could one of them somehow be null? I'm unfamiliar with the code and could miss totally though.

No, combat and mon cannot be null at this location. Besides, your crash reports actually indicate that the failure came from trying to draw the movement of a hero's flag, which is not something that should get modified by CombatAnimation as the creature count is capped at 20 as the game does itself. Remove the CombatAnimation plugin completely and see if you still get crashes - just to be certain I'm not chasing ghosts here.

bestban said:
Also, somehow the logs are no longer being generated under "...SoD_SPDebug" for new crashes.

I don't know what to say, if it was working a day ago and suddenly doesn't... you could have issues on your own end.
____________
My Let's Plays: Metataxer's Revenge - The Empire of The World 2

 Send Instant Message | Send E-Mail | View Profile | PP | Quote Reply | Link
bestban
bestban

Tavern Dweller
posted April 23, 2020 02:28 AM
Edited by bestban at 02:29, 23 Apr 2020.

RoseKavalier said:
... Remove the CombatAnimation plugin completely and see if you still get crashes - just to be certain I'm not chasing ghosts here.
...

Sure thing. I'll see how it goes after removing H3.CombatAnimation.dll from the plugin. Thanks!

 Send Instant Message | Send E-Mail | View Profile | Quote Reply | Link
wenwell
wenwell


Hired Hero
posted April 25, 2020 10:48 PM

Monsters hostility is not always displayed properly on alt+RMB. Save: https://mega.nz/file/QV4XBQya#wIqBkQRMZ2OWUJR2G6TVDYDtH-CuyOmXqidouE6eNrs

It said that minotaur kings will join Oris for 27600 gold but fight occured right after the click. Same situation is possible if it said that creatures will joind us for free.

 Send Instant Message | Send E-Mail | View Profile | Quote Reply | Link
RoseKavalier
RoseKavalier


Admirable
Supreme Hero
posted April 26, 2020 01:35 AM

wenwell said:
Monsters hostility is not always displayed properly on alt+RMB. Save: https://mega.nz/file/QV4XBQya#wIqBkQRMZ2OWUJR2G6TVDYDtH-CuyOmXqidouE6eNrs

It said that minotaur kings will join Oris for 27600 gold but fight occured right after the click. Same situation is possible if it said that creatures will joind us for free.

Thanks, there was a wrong value being used and another minor bug, gonna be uploaded soonish.
____________
My Let's Plays: Metataxer's Revenge - The Empire of The World 2

 Send Instant Message | Send E-Mail | View Profile | PP | Quote Reply | Link
bestban
bestban

Tavern Dweller
posted April 26, 2020 02:12 AM
Edited by bestban at 02:13, 26 Apr 2020.

bestban said:
RoseKavalier said:
... Remove the CombatAnimation plugin completely and see if you still get crashes - just to be certain I'm not chasing ghosts here.
...

Sure thing. I'll see how it goes after removing H3.CombatAnimation.dll from the plugin. Thanks!


Not seeing any crash after removing the H3.CombatAnimation.dll from the plugin; likely having 30+ combats already. I'll report back if I find consistently reproducible save in the future. Thanks.

Small problem: If 'Z' key is pressed, the focus is moved to the Heroes; eventually it gets stuck at the very last Hero. After this, the standard key 'H' does not work on any Hero; no Hero selection. I was unware of this 'Z' key, but it was pressed unexpectedly.

 Send Instant Message | Send E-Mail | View Profile | Quote Reply | Link
RoseKavalier
RoseKavalier


Admirable
Supreme Hero
posted April 26, 2020 04:21 AM

bestban said:

Not seeing any crash after removing the H3.CombatAnimation.dll from the plugin; likely having 30+ combats already. I'll report back if I find consistently reproducible save in the future. Thanks.

I'll add safety checks to CombatAnimation I guess.

bestban said:
Small problem: If 'Z' key is pressed, the focus is moved to the Heroes; eventually it gets stuck at the very last Hero. After this, the standard key 'H' does not work on any Hero; no Hero selection. I was unware of this 'Z' key, but it was pressed unexpectedly.

Not part of SoD_SP.
____________
My Let's Plays: Metataxer's Revenge - The Empire of The World 2

 Send Instant Message | Send E-Mail | View Profile | PP | Quote Reply | Link
Jump To: « Prev Thread . . . Next Thread » This thread is 22 pages long: 1 2 3 4 5 ... 10 ... 18 19 20 21 22 · «PREV / NEXT»
Post New Poll Post New Topic Post New Reply

Page compiled in 0.0799 seconds